Fix datatable content #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes data table content handling in BDD by properly distinguishing between cucumber data tables and examples tables, addressing issue #108.
- Introduces a heuristic to differentiate between data tables intended as cucumber arguments versus examples for parameter expansion
- Updates generated test code to properly quote column headers in data table definitions
- Adds comprehensive test coverage for the new scenario outline functionality with data table variables
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/data_tables_test.dart | Updates expected test outputs with quoted column headers and adds new test case for scenario outline with data table variables |
| lib/src/scenario_generator.dart | Implements logic to handle placeholders differently in step text versus data table arguments for scenario outlines |
| lib/src/feature_file.dart | Refactors line processing to use new data table examples detection logic |
| lib/src/data_table_parser.dart | Adds heuristic function to determine when tables should be treated as examples versus cucumber data tables |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
test/data_tables_test.dart
Outdated
| group(\'\'\'Testing feature\'\'\', () { | ||
| testWidgets(\'\'\'Outline: Testing visibility of data table in examples ('initial')\'\'\', (tester) async { | ||
| await iLoadTheSplashScreen(tester); | ||
| await iVerifyWelcomeMessagesWith(tester, 'initial', const bdd.DataTable([[text], ['Welcome']])); |
There was a problem hiding this comment.
The variable text is not quoted as a string literal. Based on the pattern in the rest of the file, this should be 'text' to match the expected string format for data table headers.
Suggested change
| await iVerifyWelcomeMessagesWith(tester, 'initial', const bdd.DataTable([[text], ['Welcome']])); | |
| await iVerifyWelcomeMessagesWith(tester, 'initial', const bdd.DataTable([['text'], ['Welcome']])); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #108
This pull request improves the handling of data tables in BDD